-
Notifications
You must be signed in to change notification settings - Fork 915
feat(actions_permissions): sha_pinning_required #2870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(actions_permissions): sha_pinning_required #2870
Conversation
6289202 to
49ad201
Compare
b88390d to
6e23078
Compare
|
I ran |
|
@nickfloyd, thanks! I guess I will only update this pull request once the provider supports go-github v79.. 🙇 |
|
@sheeeng We now have |
e98cc10 to
1bbc69f
Compare
9e57d44 to
4850248
Compare
c1b528b to
d2261b8
Compare
Fix integrations#2869. Signed-off-by: Leonard Sheng Sheng Lee <[email protected]> Signed-off-by: Leonard Sheng Sheng Lee <[email protected]>
d2261b8 to
bc214db
Compare
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheeeng I think you need to make sha_pinning_required computed as well as optional as if the user doesn't set it we're looking it up.
|
@sheeeng we're looking to release the v6.10.0 milestone today, if you don't have time to update the PR I'd be happy to finish it off for you so it makes the release? |
Wait until google/go-github#3807 is being included in the next release.Resolves #2869.
Before the change?
sha_pinning_requiredoption for actions permissions is not supported.After the change?
sha_pinning_requiredoption actions permissions is supported.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!